Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295777: java/net/httpclient/ConnectExceptionTest.java should not rely on system resolver #1779

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 27, 2023

I backport this for parity with 11.0.19-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295777: java/net/httpclient/ConnectExceptionTest.java should not rely on system resolver

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1779/head:pull/1779
$ git checkout pull/1779

Update a local copy of the PR:
$ git checkout pull/1779
$ git pull https://git.openjdk.org/jdk11u-dev pull/1779/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1779

View PR using the GUI difftool:
$ git pr show -t 1779

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1779.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 65c84e0cf890df2a604ac07213327be007227e77 8295777: java/net/httpclient/ConnectExceptionTest.java should not rely on system resolver Feb 27, 2023
@openjdk
Copy link

openjdk bot commented Feb 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 27, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8295777: java/net/httpclient/ConnectExceptionTest.java should not rely on system resolver

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 27, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 27, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 28, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 28, 2023

Going to push as commit 86b8ea8.
Since your change was applied there have been 6 commits pushed to the master branch:

  • d21d985: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails
  • 558eab2: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly
  • 6ed8694: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX
  • 18c06bb: 8279662: serviceability/sa/ClhsdbScanOops.java can fail due to unexpected GC
  • cf58d59: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64
  • 64434da: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 28, 2023
@openjdk openjdk bot closed this Feb 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2023
@openjdk
Copy link

openjdk bot commented Feb 28, 2023

@GoeLin Pushed as commit 86b8ea8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant