8235448: code cleanup in SSLContextImpl.java

[GoeLin]

I backport this as preparation for 8190492.

I had to resolve, because in 11 FIPS support is still implemented. But it's trivial cut&paste.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8235448: code cleanup in SSLContextImpl.java

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1781/head:pull/1781
$ git checkout pull/1781

Update a local copy of the PR:
$ git checkout pull/1781
$ git pull https://git.openjdk.org/jdk11u-dev pull/1781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1781

View PR using the GUI difftool:
$ git pr show -t 1781

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1781.diff

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (4141f1f1)
• 00: Full (10eb7936)

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[GoeLin]

Pre-submit fialure: unrelated build problem: /usr/bin/bash: line 1: /usr/bin/zip: Bad address

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8235448: code cleanup in SSLContextImpl.java

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 5802a9a: 8245654: Add Certigna Root CA
• 86b8ea8: 8295777: java/net/httpclient/ConnectExceptionTest.java should not rely on system resolver
• d21d985: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails
• 558eab2: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly
• 6ed8694: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX
• 18c06bb: 8279662: serviceability/sa/ClhsdbScanOops.java can fail due to unexpected GC
• cf58d59: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64
• 64434da: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 15bdc4d.
Since your change was applied there have been 8 commits pushed to the master branch:

• 5802a9a: 8245654: Add Certigna Root CA
• 86b8ea8: 8295777: java/net/httpclient/ConnectExceptionTest.java should not rely on system resolver
• d21d985: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails
• 558eab2: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly
• 6ed8694: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX
• 18c06bb: 8279662: serviceability/sa/ClhsdbScanOops.java can fail due to unexpected GC
• cf58d59: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64
• 64434da: 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:"

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 15bdc4d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.