Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316 #1784

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 28, 2023

I backport this for parity with 11.0.19-oracle.

These fail in our CI too, sometimes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1784/head:pull/1784
$ git checkout pull/1784

Update a local copy of the PR:
$ git checkout pull/1784
$ git pull https://git.openjdk.org/jdk11u-dev pull/1784/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1784

View PR using the GUI difftool:
$ git pr show -t 1784

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1784.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 545ded1a82baf62ef551b2be2a08ee29ab5d9311 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316 Feb 28, 2023
@openjdk
Copy link

openjdk bot commented Feb 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 28, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2023

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Mar 15, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • b8ac68d: 8220093: Change to GCC 8.2 for building on Linux at Oracle
  • 97809af: 8303937: Corrupted heap dumps due to missing retries for os::write()
  • c6f0085: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id
  • 939741c: 8293232: Fix race condition in pkcs11 SessionManager
  • e80528b: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
  • 479ddb6: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption
  • 7d89919: 8289301: P11Cipher should not throw out of bounds exception during padding
  • 80615a6: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation
  • 0748e2a: 8303432: Bump update version for OpenJDK: jdk-11.0.20
  • 8a726af: 8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles
  • ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/5802a9a92604585d5cb7ff03a26926486a50e1e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 15, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Mar 17, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2023

Going to push as commit 362c2e3.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 4b5fdd8: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation
  • 41ad047: 8264304: Create implementation for NSAccessibilityToolbar protocol peer
  • dd64212: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer
  • b8ac68d: 8220093: Change to GCC 8.2 for building on Linux at Oracle
  • 97809af: 8303937: Corrupted heap dumps due to missing retries for os::write()
  • c6f0085: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id
  • 939741c: 8293232: Fix race condition in pkcs11 SessionManager
  • e80528b: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
  • 479ddb6: 8280703: CipherCore.doFinal(...) causes potentially massive byte[] allocations during decryption
  • 7d89919: 8289301: P11Cipher should not throw out of bounds exception during padding
  • ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/5802a9a92604585d5cb7ff03a26926486a50e1e8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2023
@openjdk openjdk bot closed this Mar 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2023
@openjdk
Copy link

openjdk bot commented Mar 17, 2023

@GoeLin Pushed as commit 362c2e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8294548 branch March 17, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants