New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295530: Update Zlib Data Compression Library to Version 1.2.13 #1788
Conversation
Reviewed-by: alanb, jpai
👋 Welcome back sxa! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
@sxa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
What did your testing consist of? |
@phohensee I've run through the tier1 tests on Windows (results here) plus verified with some of the compression related tests from the TCK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test details. Lgtm.
Tagged the JBS issue. |
@sxa, please only integrate if you have the fix-yes label on the JBS issue. |
@GoeLin Do I need to re-trigger the |
/sponsor Got approval. |
Going to push as commit 125cf5a.
Your commit was automatically rebased without conflicts. |
@phohensee @sxa Pushed as commit 125cf5a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Stating the obvious: no. :) But next time please only issue |
Backporting zlib 1.2.13 from JDK17u due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score)
Tested on Windows which is generally the only platform I use which uses bundled zlib. This makes the
zlib
directory in the source identical to the one for JDK17u so should not cause any problems. I'll look at the feasibility of doing the same on JDK8 too.Reviewed-by: alanb, jpai
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1788/head:pull/1788
$ git checkout pull/1788
Update a local copy of the PR:
$ git checkout pull/1788
$ git pull https://git.openjdk.org/jdk11u-dev pull/1788/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1788
View PR using the GUI difftool:
$ git pr show -t 1788
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1788.diff