-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264299: Create implementation of native accessibility peer for ScrollPane and ScrollBar Java Accessibility roles #1791
Conversation
👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
|
@Autumn808 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Tagged the JBS issue. |
/integrate |
@Autumn808 |
/sponsor |
Going to push as commit 8a726af.
Your commit was automatically rebased without conflicts. |
@phohensee @Autumn808 Pushed as commit 8a726af. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
backport JDK-8264299 This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backoport JDK-8262981 is reworked and built a slider and other GUIs and components and manually tested the UI with Accessibility functions.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1791/head:pull/1791
$ git checkout pull/1791
Update a local copy of the PR:
$ git checkout pull/1791
$ git pull https://git.openjdk.org/jdk11u-dev pull/1791/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1791
View PR using the GUI difftool:
$ git pr show -t 1791
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1791.diff