-
Notifications
You must be signed in to change notification settings - Fork 253
8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly #18
Conversation
|
👋 Welcome back afarley! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@adamfarley This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
…ectly Co-authored-by: Adam Farley <afarley@openjdk.org> Co-authored-by: Aleksey Shipilev <shade@openjdk.org> Co-authored-by: Nils Eliasson <neliasso@openjdk.org> Reviewed-by: roland
|
/integrate |
|
@adamfarley |
|
/sponsor |
|
@TheRealMDoerr @adamfarley Pushed as commit d3a5ed2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit d47a77d2 from the openjdk/jdk repository.
The commit being backported was authored by Nils Eliasson on 2 Jun 2021 and was reviewed by Roland Westrelin.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/18/head:pull/18$ git checkout pull/18Update a local copy of the PR:
$ git checkout pull/18$ git pull https://git.openjdk.java.net/jdk11u-dev pull/18/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18View PR using the GUI difftool:
$ git pr show -t 18Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/18.diff