New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8220445: Support for side by side MSVC Toolset versions #180
Conversation
Co-authored-by: Ali Ince <ali.ince@gmail.com> Reviewed-by: tbell
|
This backport pull request has now been updated with issue from the original commit. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an expert, but looks okay to me. You did test it, right?
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
Thanks for the Review, Thomas. I tested it in my GitHub actions experiments and it looks promising. Will run it through SAP's testing tonight. |
/integrate |
Going to push as commit 87e300b.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 87e300b. |
This is a backport of JDK-8220445 Support for side by side MSVC Toolset versions. It is needed to support the GitHub Actions workflow for Windows because it is using the hereby introduced configure option --with-msvc-toolset-version.
The backport did not apply cleanly because JDK-8215445: Enable building for Windows in WSL is missing. I adapted the change to make it fit.
I moved the line
$ECHO "$WINPATH_BASH -c 'echo VCToolsRedistDir="'\"$VCToolsRedistDir \" >> set-vs-env.sh' \ >> $EXTRACT_VC_ENV_BAT_FILE
to the fitting place and dropped the hunk
$ECHO 'echo VCToolsRedistDir="%VCToolsRedistDir% " >> set-vs-env.sh' \ >> $EXTRACT_VC_ENV_BAT_FILE
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/180/head:pull/180
$ git checkout pull/180
Update a local copy of the PR:
$ git checkout pull/180
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/180/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 180
View PR using the GUI difftool:
$ git pr show -t 180
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/180.diff