-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264304: Create implementation for NSAccessibilityToolbar protocol peer #1804
Conversation
👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8264304
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@Autumn808 this pull request can not be integrated into git checkout JDK-8264304
git fetch https://git.openjdk.org/jdk11u-dev master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean. Reviewed.
@Autumn808 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Tagged the JBS issue. |
/integrate |
@Autumn808 |
/sponsor |
Going to push as commit 41ad047. |
@phohensee @Autumn808 Pushed as commit 41ad047. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This backport is part of the 28 backport Accessibility series JDK-8152350. Commented out line 61 of commoneComponentAccesssibilty.m until backport JDK-8262981 is reworked.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1804/head:pull/1804
$ git checkout pull/1804
Update a local copy of the PR:
$ git checkout pull/1804
$ git pull https://git.openjdk.org/jdk11u-dev pull/1804/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1804
View PR using the GUI difftool:
$ git pr show -t 1804
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1804.diff