Skip to content

Conversation

@WithEnoughCoffee
Copy link
Contributor

@WithEnoughCoffee WithEnoughCoffee commented Mar 16, 2023

This backport is part of the 28 backport Accessibility series JDK-8152350. Tested by building GUI and using the Accessibility components.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Too few reviewers with at least role reviewer found (have 0, need at least 1) (failed with the updated jcheck configuration)

Issue

  • JDK-8264305: Create implementation for native accessibility peer for Statusbar java role (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1809/head:pull/1809
$ git checkout pull/1809

Update a local copy of the PR:
$ git checkout pull/1809
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1809/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1809

View PR using the GUI difftool:
$ git pr show -t 1809

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1809.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2023

👋 Welcome back Autumn808! A progress list of the required criteria for merging this PR into pr/1808 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3025f05970ede82c6f67a0434e33b27205e10130 8264305: Create implementation for native accessibility peer for Statusbar java role Mar 16, 2023
@openjdk
Copy link

openjdk bot commented Mar 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Mar 16, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2023

Webrevs

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Apr 3, 2023
@openjdk
Copy link

openjdk bot commented Apr 3, 2023

@autumn808 this pull request can not be integrated into pr/1808 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8264305
git fetch https://git.openjdk.org/jdk11u-dev.git pr/1808
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/1808"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Apr 3, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2023

@autumn808 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1808 to pr/1807 May 13, 2023 02:55
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1807 to master June 8, 2023 17:34
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2023

@autumn808 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2023

@autumn808 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant