Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64 #1810

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Mar 16, 2023

Backport done for Oracle Parity.

Simple backport of a problem list entry. I had to resolve because 11u still has Solaris.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev pull/1810/head:pull/1810
$ git checkout pull/1810

Update a local copy of the PR:
$ git checkout pull/1810
$ git pull https://git.openjdk.org/jdk11u-dev pull/1810/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1810

View PR using the GUI difftool:
$ git pr show -t 1810

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1810.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ab2240741cfc7d10f012c1d588a92cf6f94e1de6 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64 Mar 16, 2023
@openjdk
Copy link

openjdk bot commented Mar 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 16, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Mar 16, 2023

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 16, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2023

Going to push as commit be64682.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 362c2e3: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316
  • 4b5fdd8: 8263420: Incorrect function name in NSAccessibilityStaticText native peer implementation
  • 41ad047: 8264304: Create implementation for NSAccessibilityToolbar protocol peer

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2023
@openjdk openjdk bot closed this Mar 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2023
@openjdk
Copy link

openjdk bot commented Mar 17, 2023

@RealCLanger Pushed as commit be64682.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-ab224074 branch March 17, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants