8262981: Create implementation for NSAccessibilitySlider protocol

[RealCLanger]

I propose to backport JDK-8262981 in a way that does not require a CSR. Just integrate the native code but don't touch the Java interface of javax.swing.JSlider.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8262981: Create implementation for NSAccessibilitySlider protocol
• JDK-8300791: Create implementation for NSAccessibilitySlider protocol (CSR) (Withdrawn)

Reviewers

• @Autumn808 (no known openjdk.org user name / role) ⚠️ Review applies to 5f5342b3
• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 5f5342b3

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1811/head:pull/1811
$ git checkout pull/1811

Update a local copy of the PR:
$ git checkout pull/1811
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1811/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1811

View PR using the GUI difftool:
$ git pr show -t 1811

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1811.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full (f72d2692)
• 00: Full (5f5342b3)

[RealCLanger]

/csr unneeded

[openjdk]

@RealCLanger The CSR requirement cannot be removed as there is already a CSR associated with the issue JDK-8262981. Please withdraw the CSR JDK-8300791 and then use the command /csr unneeded again.

[RealCLanger]

/csr unneeded

[openjdk]

@RealCLanger determined that a CSR request is not needed for this pull request.

[RealCLanger]

@Autumn808 @phohensee Would you mind reviewing this one (and integrating into your patch bulk)? Thx

[Autumn808]

I think this is a great fix to avoid CSR and unblock the series of backports.

[phohensee]

Works for me.

[openjdk]

@RealCLanger Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@RealCLanger This change is no longer ready for integration - check the PR body for details.

[mrserb]

This method should upcall the java part of the patch, and may throw an exception if we will skip it.

I think we should include the java part but make it private, then re-implement this next code path to call it:
accessibilityPerformDecrement->performAccessibleAction:->CAccessibility#doAccessibleAction()->JSlider

[RealCLanger]

You're right, that's a good catch. We'll need to rework that. performAccessibleAction, however, will expect an AccessibleAction, so we need to do this differently, if we can't implement this interface in JSlider.

[mrserb]

CAccessibility#doAccessibleAction() can be reworked to accept Object, and then we can switch on type of the parameter, the private methods can be accessed via SwingAccessor