Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298887: On the latest macOS+XCode the Robot API may report wrong colors #1822

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Apr 4, 2023

Hi all,
This pull request contains a backport of commit 50120396 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 22 Dec 2022 and was reviewed by Alexander Zvegintsev.

The update of the WindowAlphaCompositeTest is skipped since the JDK-8266079 is not present in jdk11u, and I do not plan to backport it now since it causes some regressions.
This patch is identical to the jdk17u version.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298887: On the latest macOS+XCode the Robot API may report wrong colors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1822/head:pull/1822
$ git checkout pull/1822

Update a local copy of the PR:
$ git checkout pull/1822
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1822/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1822

View PR using the GUI difftool:
$ git pr show -t 1822

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1822.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 50120396b6cca1219fb5dd42a11e4b29b79bd3bd 8298887: On the latest macOS+XCode the Robot API may report wrong colors Apr 4, 2023
@openjdk
Copy link

openjdk bot commented Apr 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 4, 2023
@mrserb mrserb marked this pull request as ready for review April 20, 2023 22:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 20, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it is. Lgtm.

@openjdk
Copy link

openjdk bot commented May 3, 2023

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8298887: On the latest macOS+XCode the Robot API may report wrong colors

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • fc85d95: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space
  • 26e3971: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
  • 42ae833: 8306768: CodeCache Analytics reports wrong threshold
  • aed5d6f: 8306664: GHA: Update MSVC version to latest stepping
  • c0cde47: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed
  • 2991b2b: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails
  • 31c0528: 8215015: [TESTBUG] remove unneeded -Xfuture option from tests
  • 24981cc: 8214459: NSS source should be removed
  • f26efe7: 8171426: java/lang/ProcessBuilder/Basic.java failed with Stream closed
  • 3eed850: 8187522: test/sun/net/ftp/FtpURLConnectionLeak.java timed out
  • ... and 31 more: https://git.openjdk.org/jdk11u-dev/compare/3c8c45ef3e33621f69741b6c483a513e161714ee...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 3, 2023
@mrserb
Copy link
Member Author

mrserb commented May 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 5, 2023

Going to push as commit ceb6793.
Since your change was applied there have been 43 commits pushed to the master branch:

  • e537b9d: 8303564: C2: "Bad graph detected in build_loop_late" after a CMove is wrongly split thru phi
  • a22373b: 8283059: Uninitialized warning in check_code.c with GCC 11.2
  • fc85d95: 8289735: UTIL_LOOKUP_PROGS fails on pathes with space
  • 26e3971: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
  • 42ae833: 8306768: CodeCache Analytics reports wrong threshold
  • aed5d6f: 8306664: GHA: Update MSVC version to latest stepping
  • c0cde47: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed
  • 2991b2b: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails
  • 31c0528: 8215015: [TESTBUG] remove unneeded -Xfuture option from tests
  • 24981cc: 8214459: NSS source should be removed
  • ... and 33 more: https://git.openjdk.org/jdk11u-dev/compare/3c8c45ef3e33621f69741b6c483a513e161714ee...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 5, 2023
@openjdk openjdk bot closed this May 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

@mrserb Pushed as commit ceb6793.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb-backport-50120396 branch May 5, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants