8305528: [11u] Backport of JDK-8259530 breaks build with JDK10 bootstrap VM

[yukikimmura]

Hello Christoph,

Could you review the fix please?

Thanks,
Kimura Yukihiro

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305528: [11u] Backport of JDK-8259530 breaks build with JDK10 bootstrap VM

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1823/head:pull/1823
$ git checkout pull/1823

Update a local copy of the PR:
$ git checkout pull/1823
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1823/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1823

View PR using the GUI difftool:
$ git pr show -t 1823

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1823.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back yukikimmura! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (13938241)

[RealCLanger]

Looks good and makes sense to only change HtmlDoclet.java and not the tests since these will be run with JDK 11. I'll run it through our nightlies and approve tomorrow after confirming that the issue is gone. Thanks.

[phohensee]

Lgtm.

Please tag the JBS issue.

[openjdk]

@yukikimmura This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8305528: [11u] Backport of JDK-8259530 breaks build with JDK10 bootstrap VM

Reviewed-by: phh, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[yukikimmura]

Hello Paul,

Thank you for your review.
I read the OpenJDK wiki, but I'm not familiar with the contribution process.
Should I change the label or something of JBS before typing /integrate?

Thanks,
Kimura Yukihiro

[phohensee]

Add a "jdk11u-fix-request" label to the JBS issue, and a comment titled "Fix Request (11u)" that explains the need for and risk of the backport, and what testing has been done.

[yukikimmura]

I tagged the JBS issue.
Thank you.

[phohensee]

Request looks good. Thanks for fixing this.

[yukikimmura]

Thank you for the review.
Should I just wait until fix-yes to type /integrate?
I read https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix,
but I don't understand who should add the jdk11u-fix-yes label to JBS.

Thank you,
Kimura Yukihiro

[RealCLanger]

Thank you for the review. Should I just wait until fix-yes to type /integrate? I read https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix, but I don't understand who should add the jdk11u-fix-yes label to JBS.

Yes, that's correct. Sorry for the delay, I was out of office for a few days but I just approved the backport with jdk11u-fix-yes. So you can integrate now.

The tests in our nightlies look good as well.

[yukikimmura]

/integrate

[openjdk]

@yukikimmura
Your change (at version 1393824) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit bb2e0d8.

[openjdk]

@RealCLanger @yukikimmura Pushed as commit bb2e0d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.