Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305711: Arm: C2 always enters slowpath for monitorexit #1826

Closed
wants to merge 1 commit into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Apr 8, 2023

Fixes slow thin locking on Arm.

Not a clean backport since 8241436: "C2: Factor out C2-specific code from MacroAssembler" moved the unlock function from macroAssembler.cpp to c2_MacroAssembler.cpp.

Manually tested (with -UseBiasedLocking) on Arm.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305711: Arm: C2 always enters slowpath for monitorexit

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1826/head:pull/1826
$ git checkout pull/1826

Update a local copy of the PR:
$ git checkout pull/1826
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1826/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1826

View PR using the GUI difftool:
$ git pr show -t 1826

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1826.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c67bbcea92919fea9b6f7bbcde8ba4488289d174 8305711: Arm: C2 always enters slowpath for monitorexit Apr 8, 2023
@openjdk
Copy link

openjdk bot commented Apr 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 8, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Apr 13, 2023

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8305711: Arm: C2 always enters slowpath for monitorexit

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c8e6630: 8305721: add make compile-commands artifacts to .gitignore
  • b4caafe: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile
  • bb2e0d8: 8305528: [11u] Backport of JDK-8259530 breaks build with JDK10 bootstrap VM

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 13, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Apr 17, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 17, 2023

Going to push as commit f0af8f9.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c8e6630: 8305721: add make compile-commands artifacts to .gitignore
  • b4caafe: 8274864: Remove Amman/Cairo hacks in ZoneInfoFile
  • bb2e0d8: 8305528: [11u] Backport of JDK-8259530 breaks build with JDK10 bootstrap VM

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 17, 2023
@openjdk openjdk bot closed this Apr 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2023
@openjdk
Copy link

openjdk bot commented Apr 17, 2023

@tstuefe Pushed as commit f0af8f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants