Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263432: javac may report an invalid package/class clash on case insensitive filesystems #184

Closed
wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Aug 3, 2021

Backport of JDK-8263432. Fix applies cleanly except Copyright year update. The test required manual integration and adaptation of imports.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263432: javac may report an invalid package/class clash on case insensitive filesystems

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/184/head:pull/184
$ git checkout pull/184

Update a local copy of the PR:
$ git checkout pull/184
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/184/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 184

View PR using the GUI difftool:
$ git pr show -t 184

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/184.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0a4c33826d0422af7c4cfa5f479fe0b6b0f83d23 8263432: javac may report an invalid package/class clash on case insensitive filesystems Aug 3, 2021
@openjdk
Copy link

openjdk bot commented Aug 3, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 3, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 3, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263432: javac may report an invalid package/class clash on case insensitive filesystems

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 3, 2021
@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Aug 5, 2021

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Aug 5, 2021

Going to push as commit b878e3f.
Since your change was applied there have been 9 commits pushed to the master branch:

  • f2240cc: 8221988: add possibility to build with Visual Studio 2019
  • 87e300b: 8220445: Support for side by side MSVC Toolset versions
  • d05effd: 8270893: IndexOutOfBoundsException while reading large TIFF file
  • d900e31: 8211055: Provide print to a file (PDF) feature even when printer was not connected
  • 7751352: 8230808: Remove Access::equals()
  • 35fcac6: 8168304: Make all of DependencyContext_test available in product mode
  • cf2cf25: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted
  • 0c783b0: 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280
  • aebdee3: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@TheRealMDoerr Pushed as commit b878e3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8263432_javac branch Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants