Skip to content

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Apr 21, 2023

This PR bumps the MSVC version for Windows x64 used in GHA to 14.29, just as in head and also for Windows/arm64.

The GHA tests probably won't be green until JDK-8306543 gets backported, I'll refresh this PR after it has landed.
Together with a backport of JDK-8306658 we'll be able to reduce GHA runtimes on Windows significantly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306664: GHA: Update MSVC version to latest stepping

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1845/head:pull/1845
$ git checkout pull/1845

Update a local copy of the PR:
$ git checkout pull/1845
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1845/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1845

View PR using the GUI difftool:
$ git pr show -t 1845

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1845.diff

Webrev

Link to Webrev Comment

Update MSVC 2019 fox x86_64 to the latest stepping
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 21, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 21, 2023

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8306664: GHA: Update MSVC version to latest stepping

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 21, 2023
@RealCLanger
Copy link
Contributor Author

Thanks for the review. Fix request got approved.

/integrate

@openjdk
Copy link

openjdk bot commented Apr 27, 2023

Going to push as commit aed5d6f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 27, 2023
@openjdk openjdk bot closed this Apr 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 27, 2023
@openjdk
Copy link

openjdk bot commented Apr 27, 2023

@RealCLanger Pushed as commit aed5d6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the msvcstuff branch April 27, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants