8306543: GHA: MSVC installation is failing#1846
8306543: GHA: MSVC installation is failing#1846RealCLanger wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 3c81352. |
|
@RealCLanger Pushed as commit 3c81352. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8306543, commit 5a00617b from the openjdk/jdk repository.
The commit being backported was authored by Christoph Langer on 21 Apr 2023 and was reviewed by Aleksey Shipilev and Martin Doerr.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1846/head:pull/1846$ git checkout pull/1846Update a local copy of the PR:
$ git checkout pull/1846$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1846/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1846View PR using the GUI difftool:
$ git pr show -t 1846Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1846.diff
Webrev
Link to Webrev Comment