8306768: CodeCache Analytics reports wrong threshold

[AntonKozlov]

Jcmd CodeCache_Analytics uses own implementation of threshold calculation, allowing an error to creep in, making report invalid. The suggestion is to use the existing method for free ratio calculation. After the fix, the reported values become sane.

java -XX:InitialCodeCacheSize=1G -XX:ReservedCodeCacheSize=1G ...

cmd jdk.compiler/com.sun.tools.javac.launcher.Main  Compiler.CodeHeap_Analytics | grep -A 2 "Threshold for method to be considered 'cold'"
Threshold for method to be considered 'cold':    -2037.994
min. hotness =   1016
avg. hotness =   2048
--
Threshold for method to be considered 'cold':    -2037.961
min. hotness =   1016
avg. hotness =   2048
--
Threshold for method to be considered 'cold':    -2031.906
No hotness data available

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8306768: CodeCache Analytics reports wrong threshold

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1849/head:pull/1849
$ git checkout pull/1849

Update a local copy of the PR:
$ git checkout pull/1849
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1849/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1849

View PR using the GUI difftool:
$ git pr show -t 1849

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1849.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back akozlov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (b6d70d47)

[phohensee]

Lgtm.

[openjdk]

@AntonKozlov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8306768: CodeCache Analytics reports wrong threshold

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• aed5d6f: 8306664: GHA: Update MSVC version to latest stepping
• c0cde47: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed
• 2991b2b: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails
• 31c0528: 8215015: [TESTBUG] remove unneeded -Xfuture option from tests
• 24981cc: 8214459: NSS source should be removed
• f26efe7: 8171426: java/lang/ProcessBuilder/Basic.java failed with Stream closed
• 3eed850: 8187522: test/sun/net/ftp/FtpURLConnectionLeak.java timed out
• b368809: 8209546: Make sun/security/tools/keytool/autotest.sh to support macosx
• 6dc0712: 8209167: Use CLDR's time zone mappings for Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[TobiHartmann]

Shouldn't we fix this in JDK 17u and then backport to JDK 11u?

[AntonKozlov]

You're right. Proposed openjdk/jdk17u-dev#1295. Once accepted, I'll create a backport PR. Excuse me for the a bit of extra work in reviewing that again (there is a little difference in the 11 and 17 code).

[openjdk]

⚠️ @AntonKozlov could not find any commit with hash 243e643076f70c2cfb480897e1640a21e7ac6552. Please update the title with the hash for an existing commit.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[AntonKozlov]

Reopening with Backport NNN has worked. The backport needs minor adjustment: CodeCache::reverse_free_ratio needs code blob type in jdk11 (aligned with sweeper logic).

I assume previous review counts.

[phohensee]

It does.

[AntonKozlov]

Thanks! The maintaner has also approved the change.

/integrate

[openjdk]

@AntonKozlov
Your change (at version b6d70d4) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 42ae833.
Since your change was applied there have been 9 commits pushed to the master branch:

• aed5d6f: 8306664: GHA: Update MSVC version to latest stepping
• c0cde47: 8306658: GHA: MSVC installation could be optional since it might already be pre-installed
• 2991b2b: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails
• 31c0528: 8215015: [TESTBUG] remove unneeded -Xfuture option from tests
• 24981cc: 8214459: NSS source should be removed
• f26efe7: 8171426: java/lang/ProcessBuilder/Basic.java failed with Stream closed
• 3eed850: 8187522: test/sun/net/ftp/FtpURLConnectionLeak.java timed out
• b368809: 8209546: Make sun/security/tools/keytool/autotest.sh to support macosx
• 6dc0712: 8209167: Use CLDR's time zone mappings for Windows

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @AntonKozlov Pushed as commit 42ae833.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.