8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases

[zhengxiaolinX]

Backporting JDK-8292443 as an RFE for testing. Please see the discussion thread in JDK-8292443: changes related to JDK-8207146 were dropped.

Most of code in this patch is generated by the fixed generate-unsafe-access-tests.sh after #1852.

I have verified this on x86_64 and AArch64 machines.

Thanks,
Xiaolin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases (Enhancement - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1853/head:pull/1853
$ git checkout pull/1853

Update a local copy of the PR:
$ git checkout pull/1853
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1853/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1853

View PR using the GUI difftool:
$ git pr show -t 1853

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1853.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xlinzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (fd334572)
• 01: Full - Incremental (daca63cb)
• 00: Full (b9123cf3)

[zhengxiaolinX]

May not be easy to get it reviewed:

In the mainline JDK repo to show the original commit:
git show e8bc87956abc92851de8694c56a78f6ecc546cbd > ~/1.diff

This patch:
git show b9123cf3cc > ~/2.diff

Diff the two diffs:
diff ~/1.diff ~/2.diff > diff.txt

diff.txt
Might be easier to look - the changeset is small and only the head -n 150 of it matters.

[bridgekeeper]

@zhengxiaolinX This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[phohensee]

Lgtm.

[openjdk]

@zhengxiaolinX This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8292443: Weak CAS VarHandle/Unsafe tests should test always-failing cases

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

• ccbb928: 8260878: com/sun/jdi/JdbOptions.java fails without jfr
• 193dc76: 8259796: timed CompletableFuture.get may swallow InterruptedException
• 97c07a1: 8234808: jdb quoted option parsing broken
• 5506ecf: 8254350: CompletableFuture.get may swallow InterruptedException
• cc88f4c: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling
• 4dd85cb: 8297587: Upgrade JLine to 3.22.0
• e0b98bc: 8292033: Move jdk.X509Certificate event logic to JCA layer
• b2e04df: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling
• 7f1047e: 8297955: LDAP CertStore should use LdapName and not String for DNs
• 4a7557e: 8236045: [TESTBUG] MismatchedWhiteBox test fails with missing WhiteBox$WhiteBoxPermission.class
• ... and 70 more: https://git.openjdk.org/jdk11u-dev/compare/589894526da90bc9beb69033ce76d540c4a19501...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[zhengxiaolinX]

Got the jdk11u-fix-yes approval.

/integrate

[openjdk]

@zhengxiaolinX
Your change (at version fd33457) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 398f413.
Since your change was applied there have been 83 commits pushed to the master branch:

• 480b23d: 8218471: generate-unsafe-access-tests.sh does not correctly invoke build.tools.spp.Spp
• 08e0d08: 8310620: [11u] Problemlist failing aot tests on macos x64
• 770c1f6: 8293562: KeepAliveCache Blocks Threads while Closing Connections
• ccbb928: 8260878: com/sun/jdi/JdbOptions.java fails without jfr
• 193dc76: 8259796: timed CompletableFuture.get may swallow InterruptedException
• 97c07a1: 8234808: jdb quoted option parsing broken
• 5506ecf: 8254350: CompletableFuture.get may swallow InterruptedException
• cc88f4c: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling
• 4dd85cb: 8297587: Upgrade JLine to 3.22.0
• e0b98bc: 8292033: Move jdk.X509Certificate event logic to JCA layer
• ... and 73 more: https://git.openjdk.org/jdk11u-dev/compare/589894526da90bc9beb69033ce76d540c4a19501...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @zhengxiaolinX Pushed as commit 398f413.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.