8214807: Improve handling of very old class files

[RealLucy]

I back port this for parity with Oracle JDK 11.0.20.

Backport didn't integrate cleanly. In JDK 11, the cmdline option -XX:+RelaxAccessControlCheck can't be removed. It was deprecated in JDK 16.

Reviews are very welcome.

SAP-internal tests don't show any issues.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8214807: Improve handling of very old class files

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1860/head:pull/1860
$ git checkout pull/1860

Update a local copy of the PR:
$ git checkout pull/1860
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1860/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1860

View PR using the GUI difftool:
$ git pr show -t 1860

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1860.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[mlbridge]

Webrevs

• 00: Full (aaf34fd5)

[RealCLanger]

Hi @RealLucy,

I think you should do the changes to the man files as well. For 11u, you'll find them per platform below src//doc/man.

[RealLucy]

I think you should do the changes to the man files as well.

I left out the man page changes by intention. The option was deprecated with jdk15 and removed with jdk16. There was no deprecation process for jdk11.

[RealCLanger]

I think you should do the changes to the man files as well.

I left out the man page changes by intention. The option was deprecated with jdk15 and removed with jdk16. There was no deprecation process for jdk11.

Yes, but the change did not deprecate/remove an option. It just removes some text about this option from the man page, which is fine and desired, I guess. I'll however approve this PR and leave it to you whether you modify the man pages in the backport - I guess it's a matter of taste.

[openjdk]

@RealLucy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8214807: Improve handling of very old class files

Remove old version specific code in reflection.cpp

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• b46e240: 8285497: Add system property for Java SE specification maintenance version
• 9317eec: 8282467: add extra diagnostics for JDK-8268184
• 12093c0: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
• f5da5da: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
• 804ed83: 8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2
• 75c5063: 8301401: Allow additional characters for GB18030-2022 support
• 63cb8a1: 8301998: Update HarfBuzz to 7.0.1
• d8f1a34: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
• 7e93c80: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
• 521833e: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
• ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/e537b9d740871f2600f15830e0923b9dbfec3ce1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealLucy]

/integrate

[openjdk]

Going to push as commit ca62ba5.
Since your change was applied there have been 21 commits pushed to the master branch:

• b46e240: 8285497: Add system property for Java SE specification maintenance version
• 9317eec: 8282467: add extra diagnostics for JDK-8268184
• 12093c0: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
• f5da5da: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
• 804ed83: 8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2
• 75c5063: 8301401: Allow additional characters for GB18030-2022 support
• 63cb8a1: 8301998: Update HarfBuzz to 7.0.1
• d8f1a34: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
• 7e93c80: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
• 521833e: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
• ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/e537b9d740871f2600f15830e0923b9dbfec3ce1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealLucy Pushed as commit ca62ba5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.