Skip to content

8303476: Add the runtime version in the release file of a JDK image #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 5, 2023

I backport this for parity with 11.0.20-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8306655 to be approved

Issues

  • JDK-8303476: Add the runtime version in the release file of a JDK image
  • JDK-8306655: Add JAVA_RUNTIME_VERSION in the release file of a JDK image (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1863/head:pull/1863
$ git checkout pull/1863

Update a local copy of the PR:
$ git checkout pull/1863
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1863/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1863

View PR using the GUI difftool:
$ git pr show -t 1863

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1863.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 32247c336a189a40f696626a2578c65535ef6376 8303476: Add the runtime version in the release file of a JDK image May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels May 5, 2023
@mlbridge
Copy link

mlbridge bot commented May 5, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented May 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 8, 2023

@GoeLin This pull request has not yet been marked as ready for integration.

@openjdk
Copy link

openjdk bot commented May 9, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8303476: Add the runtime version in the release file of a JDK image

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 1f601e9: 8303861: Error handling step timeouts should never be blocked by OnError and others
  • 8c243a3: 8305400: ISO 4217 Amendment 175 Update
  • 2c8069c: 8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter
  • 93d1d22: 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies
  • 5a574ea: 8286398: Address possibly lossy conversions in jdk.internal.le
  • ceb6793: 8298887: On the latest macOS+XCode the Robot API may report wrong colors

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration ready Pull request is ready to be integrated labels May 9, 2023
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 9, 2023
@GoeLin
Copy link
Member Author

GoeLin commented May 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2023

Going to push as commit 4548929.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 1f601e9: 8303861: Error handling step timeouts should never be blocked by OnError and others
  • 8c243a3: 8305400: ISO 4217 Amendment 175 Update
  • 2c8069c: 8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter
  • 93d1d22: 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies
  • 5a574ea: 8286398: Address possibly lossy conversions in jdk.internal.le
  • ceb6793: 8298887: On the latest macOS+XCode the Robot API may report wrong colors

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2023
@openjdk openjdk bot closed this May 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2023
@openjdk
Copy link

openjdk bot commented May 10, 2023

@GoeLin Pushed as commit 4548929.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant