Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301998: Update HarfBuzz to 7.0.1 #1864

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 8, 2023

I backport this for parity with 11.0.20-oracle.

I had to resolve the makefile. Trivial.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1864/head:pull/1864
$ git checkout pull/1864

Update a local copy of the PR:
$ git checkout pull/1864
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1864

View PR using the GUI difftool:
$ git pr show -t 1864

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1864.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f969f811a71603f39e4ab42f1362271b7a4d303d 8301998: Update HarfBuzz to 7.0.1 May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 8, 2023
@mlbridge
Copy link

mlbridge bot commented May 8, 2023

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented May 9, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301998: Update HarfBuzz to 7.0.1
8304295: harfbuzz build fails with GCC 7 after JDK-8301998

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 8c243a3: 8305400: ISO 4217 Amendment 175 Update
  • 2c8069c: 8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter
  • 93d1d22: 8287897: Augment src/jdk.internal.le/share/legal/jline.md with information on 4th party dependencies
  • 5a574ea: 8286398: Address possibly lossy conversions in jdk.internal.le
  • ceb6793: 8298887: On the latest macOS+XCode the Robot API may report wrong colors

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2023
@GoeLin
Copy link
Member Author

GoeLin commented May 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2023

Going to push as commit 63cb8a1.
Since your change was applied there have been 14 commits pushed to the master branch:

  • d8f1a34: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • 7e93c80: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
  • 521833e: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
  • 2995d08: 8209880: tzdb.dat is not reproducibly built
  • 1f49004: 8248701: On Windows generated modules-deps.gmk can contain backslash-r (CR) characters
  • 7b2d5fc: 8257856: Make ClassFileVersionsTest.java robust to JDK version updates
  • 6a28ccb: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
  • 4548929: 8303476: Add the runtime version in the release file of a JDK image
  • 1f601e9: 8303861: Error handling step timeouts should never be blocked by OnError and others
  • 8c243a3: 8305400: ISO 4217 Amendment 175 Update
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/e537b9d740871f2600f15830e0923b9dbfec3ce1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2023
@openjdk openjdk bot closed this May 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2023
@openjdk
Copy link

openjdk bot commented May 10, 2023

@GoeLin Pushed as commit 63cb8a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8301998 branch May 10, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants