8282467: add extra diagnostics for JDK-8268184

[RealCLanger]

Hi all,

This pull request contains a backport of JDK-8282467, commit 2903d59a from the openjdk/jdk17u-dev repository.

The commit being backported was authored by Goetz Lindenmaier on 8 Jun 2022 and had no reviewers.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8282467: add extra diagnostics for JDK-8268184

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1869/head:pull/1869
$ git checkout pull/1869

Update a local copy of the PR:
$ git checkout pull/1869
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1869/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1869

View PR using the GUI difftool:
$ git pr show -t 1869

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1869.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282467: add extra diagnostics for JDK-8268184

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 1f49004: 8248701: On Windows generated modules-deps.gmk can contain backslash-r (CR) characters
• 7b2d5fc: 8257856: Make ClassFileVersionsTest.java robust to JDK version updates
• 6a28ccb: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
• 4548929: 8303476: Add the runtime version in the release file of a JDK image
• 1f601e9: 8303861: Error handling step timeouts should never be blocked by OnError and others

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (b29848e8)
• 00: Full (1350be98)

[TheRealMDoerr]

I think the cast to int is ok as workaround for wrong gcc warnings in GHA. (fegetround is specified to return an int, so, the cast is basically a nop.)

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 9317eec.
Since your change was applied there have been 14 commits pushed to the master branch:

• 12093c0: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
• f5da5da: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
• 804ed83: 8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2
• 75c5063: 8301401: Allow additional characters for GB18030-2022 support
• 63cb8a1: 8301998: Update HarfBuzz to 7.0.1
• d8f1a34: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
• 7e93c80: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
• 521833e: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
• 2995d08: 8209880: tzdb.dat is not reproducibly built
• 1f49004: 8248701: On Windows generated modules-deps.gmk can contain backslash-r (CR) characters
• ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/8c243a33b290f5e747ee227f005d30260e6d846f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 9317eec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.