Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows #1874

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 8, 2023

I skipped the changes to building.html/building.md because this would simply be wrong for 11u. Also, changing jib-profiles.js is pointless. However, the updates to createWindowsDevkit.sh are good to have and apply cleanly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8283723 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1874/head:pull/1874
$ git checkout pull/1874

Update a local copy of the PR:
$ git checkout pull/1874
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1874/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1874

View PR using the GUI difftool:
$ git pr show -t 1874

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1874.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6fa5281c6b7df007a89c0b6e8a7e268a06927540 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows May 8, 2023
@openjdk
Copy link

openjdk bot commented May 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 8, 2023
@mlbridge
Copy link

mlbridge bot commented May 8, 2023

Webrevs

@RealCLanger RealCLanger closed this May 9, 2023
@RealCLanger RealCLanger reopened this May 9, 2023
Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The script now needs a parameter for the Visual Studio version, but this should not be a big issue for such an internal helper script.

@openjdk
Copy link

openjdk bot commented May 10, 2023

@RealCLanger This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2023
@GoeLin
Copy link
Member

GoeLin commented May 11, 2023

Hi @RealCLanger
I am not so sure we should do this as backport with all the leftouts.
Also, changes touching building.html and jib are frequent, so backporting
will get more complicated if we sometimes backport changes and somtimes leave them out.

@RealCLanger
Copy link
Contributor Author

Hi @RealCLanger I am not so sure we should do this as backport with all the leftouts. Also, changes touching building.html and jib are frequent, so backporting will get more complicated if we sometimes backport changes and somtimes leave them out.

Hm, I think the risk is low as it does not affect the product but only improves the script to generate devkits. Regarding changes to building.html: Here we will have to diff to upstream releases since build environments remain different. And, jib is something that OpenJDK does not care.

After all, I leave it to you to approve or reject. In the latter case we can flag the bug jdk11u-na

@GoeLin
Copy link
Member

GoeLin commented May 25, 2023

I agree the change to the dev kit are good, but this is just not a backport of the change.
I guess you should open issue "[11u] backport VS2022 devkit changes of 8283723" or the like for this change.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2023

@RealCLanger This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Sep 26, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 26, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

@RealCLanger This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@RealCLanger
Copy link
Contributor Author

Closing as per @GoeLin's comment.

@RealCLanger RealCLanger deleted the RealCLanger-backport-6fa5281c branch October 25, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
3 participants