-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2 #1877
Conversation
Reviewed-by: lance.andersen Backport-of: 0a700c6c3d150ed375c113b31b8e6185cbe57ae6
…or GB 18030-2022 Implementation Level 2 Reviewed-by: lance.andersen Backport-of: 926910977080dda181ae3772293d2bc9bd458f2a
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
@naotoj This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 804ed83.
Your commit was automatically rebased without conflicts. |
This is a backport of GB18030 Level 2 part of the JSR384 MR2 (https://jcp.org/aboutJava/communityprocess/mrel/jsr384/index2.html) Reference Implementation
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1877/head:pull/1877
$ git checkout pull/1877
Update a local copy of the PR:
$ git checkout pull/1877
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1877/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1877
View PR using the GUI difftool:
$ git pr show -t 1877
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1877.diff
Webrev
Link to Webrev Comment