Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2 #1877

Closed
wants to merge 2 commits into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented May 9, 2023

This is a backport of GB18030 Level 2 part of the JSR384 MR2 (https://jcp.org/aboutJava/communityprocess/mrel/jsr384/index2.html) Reference Implementation


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1877/head:pull/1877
$ git checkout pull/1877

Update a local copy of the PR:
$ git checkout pull/1877
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1877/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1877

View PR using the GUI difftool:
$ git pr show -t 1877

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1877.diff

Webrev

Link to Webrev Comment

naotoj added 2 commits May 8, 2023 20:07
Reviewed-by: lance.andersen
Backport-of: 0a700c6c3d150ed375c113b31b8e6185cbe57ae6
…or GB 18030-2022 Implementation Level 2

Reviewed-by: lance.andersen
Backport-of: 926910977080dda181ae3772293d2bc9bd458f2a
@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2023

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into pr/1876 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 926910977080dda181ae3772293d2bc9bd458f2a 8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2 May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

This backport pull request has now been updated with issue from the original commit.

@naotoj naotoj marked this pull request as ready for review May 9, 2023 19:31
@openjdk openjdk bot added the rfr Pull request is ready for review label May 9, 2023
@mlbridge
Copy link

mlbridge bot commented May 9, 2023

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@naotoj naotoj changed the base branch from pr/1876 to master May 10, 2023 18:13
@openjdk openjdk bot removed the clean label May 10, 2023
@openjdk
Copy link

openjdk bot commented May 10, 2023

@naotoj This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2

Reviewed-by: lancea, iris, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 75c5063: 8301401: Allow additional characters for GB18030-2022 support
  • 63cb8a1: 8301998: Update HarfBuzz to 7.0.1
  • d8f1a34: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • 7e93c80: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
  • 521833e: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
  • 2995d08: 8209880: tzdb.dat is not reproducibly built
  • 1f49004: 8248701: On Windows generated modules-deps.gmk can contain backslash-r (CR) characters
  • 7b2d5fc: 8257856: Make ClassFileVersionsTest.java robust to JDK version updates
  • 6a28ccb: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
  • 4548929: 8303476: Add the runtime version in the release file of a JDK image
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/8c243a33b290f5e747ee227f005d30260e6d846f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2023
@naotoj
Copy link
Member Author

naotoj commented May 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2023

Going to push as commit 804ed83.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 75c5063: 8301401: Allow additional characters for GB18030-2022 support
  • 63cb8a1: 8301998: Update HarfBuzz to 7.0.1
  • d8f1a34: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • 7e93c80: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
  • 521833e: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
  • 2995d08: 8209880: tzdb.dat is not reproducibly built
  • 1f49004: 8248701: On Windows generated modules-deps.gmk can contain backslash-r (CR) characters
  • 7b2d5fc: 8257856: Make ClassFileVersionsTest.java robust to JDK version updates
  • 6a28ccb: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
  • 4548929: 8303476: Add the runtime version in the release file of a JDK image
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/8c243a33b290f5e747ee227f005d30260e6d846f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2023
@openjdk openjdk bot closed this May 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2023
@openjdk
Copy link

openjdk bot commented May 10, 2023

@naotoj Pushed as commit 804ed83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants