Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285497: Add system property for Java SE specification maintenance version #1878

Closed
wants to merge 1 commit into from

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented May 9, 2023

Please review this change which is a backport of the java.specification.maintenance.version system property part of the JSR384 MR2 Reference Implementation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285497: Add system property for Java SE specification maintenance version

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1878/head:pull/1878
$ git checkout pull/1878

Update a local copy of the PR:
$ git checkout pull/1878
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1878/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1878

View PR using the GUI difftool:
$ git pr show -t 1878

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1878.diff

Webrev

Link to Webrev Comment

…rsion

Reviewed-by: lancea, darcy, naoto, iris, clanger
Backport-of: 59ef76a365eafe40d8d68b4d5e028f0e731abd01
@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 59ef76a365eafe40d8d68b4d5e028f0e731abd01 8285497: Add system property for Java SE specification maintenance version May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285497: Add system property for Java SE specification maintenance version

Reviewed-by: lancea, rriggs, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 9317eec: 8282467: add extra diagnostics for JDK-8268184
  • 12093c0: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • f5da5da: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • 804ed83: 8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2
  • 75c5063: 8301401: Allow additional characters for GB18030-2022 support
  • 63cb8a1: 8301998: Update HarfBuzz to 7.0.1
  • d8f1a34: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • 7e93c80: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
  • 521833e: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
  • 2995d08: 8209880: tzdb.dat is not reproducibly built
  • ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/ceb6793bf3b5855c7c521678b5d99d752800b441...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen, @RogerRiggs, @naotoj, @irisclark) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 9, 2023
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes match those in jdk11u-ri. Thanks!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 9, 2023
@mlbridge
Copy link

mlbridge bot commented May 9, 2023

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2023
@justin-curtis-lu justin-curtis-lu changed the title 8285497: Add system property for Java SE specification maintenance version Backport e5ac7a1b7e8df1e56a7e78bba6a2b9ed7fc297f1 May 9, 2023
@openjdk openjdk bot changed the title Backport e5ac7a1b7e8df1e56a7e78bba6a2b9ed7fc297f1 8285497: Add system property for Java SE specification maintenance version May 9, 2023
@openjdk
Copy link

openjdk bot commented May 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 9, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@justin-curtis-lu
Your change (at version 00b68d1) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented May 11, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented May 11, 2023

Going to push as commit b46e240.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 9317eec: 8282467: add extra diagnostics for JDK-8268184
  • 12093c0: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • f5da5da: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • 804ed83: 8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2
  • 75c5063: 8301401: Allow additional characters for GB18030-2022 support
  • 63cb8a1: 8301998: Update HarfBuzz to 7.0.1
  • d8f1a34: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • 7e93c80: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
  • 521833e: 8282077: PKCS11 provider C_sign() impl should handle CKR_BUFFER_TOO_SMALL error
  • 2995d08: 8209880: tzdb.dat is not reproducibly built
  • ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/ceb6793bf3b5855c7c521678b5d99d752800b441...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 11, 2023
@openjdk openjdk bot closed this May 11, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 11, 2023
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 11, 2023
@openjdk
Copy link

openjdk bot commented May 11, 2023

@naotoj @justin-curtis-lu Pushed as commit b46e240.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants