Skip to content

8307811: [TEST] compilation of TimeoutInErrorHandlingTest fails after backport of JDK-8303861 #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8307811: [TEST] compilation of TimeoutInErrorHandlingTest fails after backport of JDK-8303861 #1882

wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented May 10, 2023 •
edited by openjdk bot
Loading

Hi!

This one fixes compilation of

runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java

broken by backport of JDK-8303861. The problem is about backported delta refers to ERROR_LOG_TIMEOUT member that was introduced by different changeset and so was not backported and it stayed covered because the test is selected only for debug VM build

Verification/regression (amd64/20.04LTS):

alex@alex-VirtualBox:~/jdk11u-dev$ /opt/jtreg/bin/jtreg -v -jdk:./build/linux-x86_64-normal-server-fastdebug/images/jdk test/hotspot/jtreg/runtime/ErrorHandling
runner starting test: runtime/ErrorHandling/BadNativeStackInErrorHandlingTest.java
runner finished test: runtime/ErrorHandling/BadNativeStackInErrorHandlingTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/CreateCoredumpOnCrash.java
runner finished test: runtime/ErrorHandling/CreateCoredumpOnCrash.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/ErrorFileRedirectTest.java
runner finished test: runtime/ErrorHandling/ErrorFileRedirectTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/ErrorHandler.java
runner finished test: runtime/ErrorHandling/ErrorHandler.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java
runner finished test: runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/ProblematicFrameTest.java
runner finished test: runtime/ErrorHandling/ProblematicFrameTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/SafeFetchInErrorHandlingTest.java
runner finished test: runtime/ErrorHandling/SafeFetchInErrorHandlingTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/SecondaryErrorTest.java
runner finished test: runtime/ErrorHandling/SecondaryErrorTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/ShowRegistersOnAssertTest.java
runner finished test: runtime/ErrorHandling/ShowRegistersOnAssertTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestCrashOnOutOfMemoryError.java
runner finished test: runtime/ErrorHandling/TestCrashOnOutOfMemoryError.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestExitOnOutOfMemoryError.java
runner finished test: runtime/ErrorHandling/TestExitOnOutOfMemoryError.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java
runner finished test: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryErrorInMetaspace.java
runner finished test: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryErrorInMetaspace.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestHeapDumpPath.java
runner finished test: runtime/ErrorHandling/TestHeapDumpPath.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestOnError.java
runner finished test: runtime/ErrorHandling/TestOnError.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TestOnOutOfMemoryError.java
runner finished test: runtime/ErrorHandling/TestOnOutOfMemoryError.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java
runner finished test: runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TimeoutInErrorHandlingTest.java#default
runner finished test: runtime/ErrorHandling/TimeoutInErrorHandlingTest.java#default
Passed. Execution successful
runner starting test: runtime/ErrorHandling/TimeoutInErrorHandlingTest.java#with-on-error
runner finished test: runtime/ErrorHandling/TimeoutInErrorHandlingTest.java#with-on-error
Passed. Execution successful
runner starting test: runtime/ErrorHandling/VeryEarlyAssertTest.java
runner finished test: runtime/ErrorHandling/VeryEarlyAssertTest.java
Passed. Execution successful
Test results: passed: 20
Report written to /home/alex/jdk11u-dev/JTreport/html/report.html
Results written to /home/alex/jdk11u-dev/JTwork
alex@alex-VirtualBox:~/jdk11u-dev$

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307811: [TEST] compilation of TimeoutInErrorHandlingTest fails after backport of JDK-8303861

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1882/head:pull/1882
$ git checkout pull/1882

Update a local copy of the PR:
$ git checkout pull/1882
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1882/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1882

View PR using the GUI difftool:
$ git pr show -t 1882

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1882.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2023

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2023
@mlbridge
Copy link

mlbridge bot commented May 10, 2023

Webrevs

phohensee
phohensee reviewed May 10, 2023
View reviewed changes
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the different changeset worth backporting on its own, rather than doing this patch?

@openjdk
Copy link

openjdk bot commented May 10, 2023 •
edited
Loading

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307811: [TEST] compilation of TimeoutInErrorHandlingTest fails after backport of JDK-8303861

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • ca62ba5: 8214807: Improve handling of very old class files
  • b46e240: 8285497: Add system property for Java SE specification maintenance version
  • 9317eec: 8282467: add extra diagnostics for JDK-8268184
  • 12093c0: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • f5da5da: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • 804ed83: 8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2
  • 75c5063: 8301401: Allow additional characters for GB18030-2022 support
  • 63cb8a1: 8301998: Update HarfBuzz to 7.0.1
  • d8f1a34: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • 7e93c80: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/1f49004e6a3f3626b725b240488f004083128b2a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2023
@RealCLanger
Copy link
Contributor

Is the different changeset worth backporting on its own, rather than doing this patch?

Maybe. But this minimal change to the test is good on its own, assuming it fixes the failing test case.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels May 11, 2023
@GoeLin
Copy link
Member

GoeLin commented May 11, 2023

Hi, why are the Pre-submit tests failing?

@apavlyutkin
Copy link
Contributor Author

I'll check it but for sure this does not relate to fixed test because it's disabled for Windows

/*
 * @test id=default
 * @bug 8166944
 * @summary Hanging Error Reporting steps may lead to torn error logs
 * @modules java.base/jdk.internal.misc
 * @library /test/lib
 * @requires (vm.debug == true) & (os.family != "windows")
 * @author Thomas Stuefe (SAP)
 */
/*
 * @test id=with-on-error
 * @bug 8303861
 * @summary Error handling step timeouts should never be blocked by OnError etc.
 * @modules java.base/jdk.internal.misc
 * @library /test/lib
 * @requires (vm.debug == true) & (os.family != "windows")
 * @run driver TimeoutInErrorHandlingTest with-on-error
 */

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 12, 2023
@openjdk
Copy link

openjdk bot commented May 12, 2023

@apavlyutkin
Your change (at version aceead7) is now ready to be sponsored by a Committer.

@yan-too
Copy link

yan-too commented May 12, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented May 12, 2023

Going to push as commit 0ef2e11.
Since your change was applied there have been 12 commits pushed to the master branch:

  • ca62ba5: 8214807: Improve handling of very old class files
  • b46e240: 8285497: Add system property for Java SE specification maintenance version
  • 9317eec: 8282467: add extra diagnostics for JDK-8268184
  • 12093c0: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • f5da5da: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • 804ed83: 8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2
  • 75c5063: 8301401: Allow additional characters for GB18030-2022 support
  • 63cb8a1: 8301998: Update HarfBuzz to 7.0.1
  • d8f1a34: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • 7e93c80: 8292206: TestCgroupMetrics.java fails as getMemoryUsage() is lower than expected
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/1f49004e6a3f3626b725b240488f004083128b2a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 12, 2023
@openjdk openjdk bot closed this May 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 12, 2023
@openjdk
Copy link

openjdk bot commented May 12, 2023

@yan-too @apavlyutkin Pushed as commit 0ef2e11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phohensee phohensee phohensee left review comments

@RealCLanger RealCLanger RealCLanger approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apavlyutkin @RealCLanger @GoeLin @yan-too @phohensee