Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented May 12, 2023

Backport 8282201


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282201: Consider removal of expiry check in VerifyCACerts.java test

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1883/head:pull/1883
$ git checkout pull/1883

Update a local copy of the PR:
$ git checkout pull/1883
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1883

View PR using the GUI difftool:
$ git pr show -t 1883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1883.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5b43804b7988ea4abd6458fba0a042b7bd6d9cb8 8282201: Consider removal of expiry check in VerifyCACerts.java test May 12, 2023
@openjdk
Copy link

openjdk bot commented May 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 12, 2023
@mlbridge
Copy link

mlbridge bot commented May 12, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented May 15, 2023

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282201: Consider removal of expiry check in VerifyCACerts.java test

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 0ef2e11: 8307811: [TEST] compilation of TimeoutInErrorHandlingTest fails after backport of JDK-8303861
  • ca62ba5: 8214807: Improve handling of very old class files

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 15, 2023
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 15, 2023

Going to push as commit 507a392.
Since your change was applied there have been 4 commits pushed to the master branch:

  • be0de41: 8308006: Missing NMT memory tagging in CMS
  • 2f6a287: 8303822: gtestMain should give more helpful output
  • 0ef2e11: 8307811: [TEST] compilation of TimeoutInErrorHandlingTest fails after backport of JDK-8303861
  • ca62ba5: 8214807: Improve handling of very old class files

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 15, 2023
@openjdk openjdk bot closed this May 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 15, 2023
@openjdk
Copy link

openjdk bot commented May 15, 2023

@MBaesken Pushed as commit 507a392.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants