Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307134: Add GTS root CAs #1892

Closed
wants to merge 2 commits into from

Conversation

jianglizhou
Copy link
Contributor

@jianglizhou jianglizhou commented May 23, 2023

Backport to JDK 11u for parity with 11.0.21-oracle.

Manually merged:

  • Placed new cacert files under make/data/cacerts/.
  • Updated CHECKSUM in test/jdk/sun/security/lib/cacerts/VerifyCACerts.java.

Tested both test/jdk/security/infra/java/security/cert/CertPathValidator/certification/GoogleCA.java and test/jdk/sun/security/lib/cacerts/VerifyCACerts.java with JDK 11 test binary.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1892/head:pull/1892
$ git checkout pull/1892

Update a local copy of the PR:
$ git checkout pull/1892
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1892/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1892

View PR using the GUI difftool:
$ git pr show -t 1892

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1892.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2023

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03030d47ebee5c20919fe0162ec86d3d400cd955 8307134: Add GTS root CAs May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 23, 2023
@mlbridge
Copy link

mlbridge bot commented May 23, 2023

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented May 24, 2023

@jianglizhou Please enable testing on your fork. Thanks.

@jianglizhou
Copy link
Contributor Author

@jianglizhou Please enable testing on your fork. Thanks.

Done, thanks.

I'll look into starting the workflow ...

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Almost clean to the 17u-dev version. Only context differences in a test. Thanks!

@openjdk
Copy link

openjdk bot commented May 24, 2023

@jianglizhou This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307134: Add GTS root CAs

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2023
@jianglizhou
Copy link
Contributor Author

Looks fine to me. Almost clean to the 17u-dev version. Only context differences in a test. Thanks!

Thanks for the review.

@GoeLin
Copy link
Member

GoeLin commented May 25, 2023

Hi @jianglizhou, please enable GHA tests and restart them by merging head!

@jianglizhou
Copy link
Contributor Author

Hi @jianglizhou, please enable GHA tests and restart them by merging head!

Restarted test workflow by merging head. Thanks.

@GoeLin
Copy link
Member

GoeLin commented May 26, 2023

Thanks!

@jianglizhou
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 26, 2023

Going to push as commit 8a0b64b.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 5401f12: 8287007: [cgroups] Consistently use stringStream throughout parsing code
  • 5c4e744: 8301119: Support for GB18030-2022
  • 682728e: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression
  • 2e01473: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 26, 2023
@openjdk openjdk bot closed this May 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2023
@openjdk
Copy link

openjdk bot commented May 26, 2023

@jianglizhou Pushed as commit 8a0b64b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants