-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8307134: Add GTS root CAs #1892
Conversation
👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
@jianglizhou Please enable testing on your fork. Thanks. |
Done, thanks. I'll look into starting the workflow ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Almost clean to the 17u-dev version. Only context differences in a test. Thanks!
@jianglizhou This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review. |
Hi @jianglizhou, please enable GHA tests and restart them by merging head! |
Restarted test workflow by merging head. Thanks. |
Thanks! |
/integrate |
Going to push as commit 8a0b64b.
Your commit was automatically rebased without conflicts. |
@jianglizhou Pushed as commit 8a0b64b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport to JDK 11u for parity with 11.0.21-oracle.
Manually merged:
CHECKSUM
in test/jdk/sun/security/lib/cacerts/VerifyCACerts.java.Tested both test/jdk/security/infra/java/security/cert/CertPathValidator/certification/GoogleCA.java and test/jdk/sun/security/lib/cacerts/VerifyCACerts.java with JDK 11 test binary.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1892/head:pull/1892
$ git checkout pull/1892
Update a local copy of the PR:
$ git checkout pull/1892
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1892/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1892
View PR using the GUI difftool:
$ git pr show -t 1892
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1892.diff
Webrev
Link to Webrev Comment