-
Notifications
You must be signed in to change notification settings - Fork 251
8275735: [linux] Remove deprecated Metrics api (kernel memory limit) #1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back lucy! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
jerboaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Differences are caused by JDK-8227317 and a comment difference introduced with the cgroups v2 backport to 11. Thumbs up.
|
@RealLucy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit c0ae141. |
This backport is for parity with Oracle JDK 11.
The patch did not apply cleanly. I first had to adapt the jdk11u-dev files. These adaptations are visible in the first commit. The second commit contains the changes brought in by the original patch which then applied cleanly.
Reviews are very much appreciated.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1893/head:pull/1893$ git checkout pull/1893Update a local copy of the PR:
$ git checkout pull/1893$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1893/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1893View PR using the GUI difftool:
$ git pr show -t 1893Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1893.diff
Webrev
Link to Webrev Comment