Skip to content

Conversation

@RealLucy
Copy link
Contributor

@RealLucy RealLucy commented May 25, 2023

This backport is a prerequisite to easily backport JDK-8260274 (required for 11.0.20-oracle parity). The patch applies cleanly except for copyright header mismatches.

Tests (GHA and SAP internal) successful.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8246383: NullPointerException in JceSecurity.getVerificationResult when using Entrust provider

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1901/head:pull/1901
$ git checkout pull/1901

Update a local copy of the PR:
$ git checkout pull/1901
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1901

View PR using the GUI difftool:
$ git pr show -t 1901

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1901.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2023

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03f2ab325d30b74095f8abec8dbe09def27950c7 8246383: NullPointerException in JceSecurity.getVerificationResult when using Entrust provider May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 25, 2023
@mlbridge
Copy link

mlbridge bot commented May 25, 2023

Webrevs

@RealLucy
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@RealLucy This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented May 25, 2023

@RealLucy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8246383: NullPointerException in JceSecurity.getVerificationResult when using Entrust provider

Removed the static SecureRandom object in JceSecurity whose instantion caused NPE

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 682728e: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression
  • 2e01473: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java
  • 5fa213a: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 25, 2023
@RealLucy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2023

Going to push as commit 9eded68.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 1cbdcc9: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
  • b3d6981: 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE
  • 8a0b64b: 8307134: Add GTS root CAs
  • 5401f12: 8287007: [cgroups] Consistently use stringStream throughout parsing code
  • 5c4e744: 8301119: Support for GB18030-2022
  • 682728e: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression
  • 2e01473: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java
  • 5fa213a: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2023
@openjdk openjdk bot closed this May 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

@RealLucy Pushed as commit 9eded68.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant