Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303809: Dispose context in SPNEGO NegotiatorImpl #1906

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented May 26, 2023

Clean backport from OpenJDK17

sun/security/jgss sun/security/krb5 sun/net/www/protocol/http tests passed successfully


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303809: Dispose context in SPNEGO NegotiatorImpl

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1906/head:pull/1906
$ git checkout pull/1906

Update a local copy of the PR:
$ git checkout pull/1906
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1906/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1906

View PR using the GUI difftool:
$ git pr show -t 1906

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1906.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2023

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 10f16746254ce62031f40ffb0f49f22e81cbe631 8303809: Dispose context in SPNEGO NegotiatorImpl May 26, 2023
@openjdk
Copy link

openjdk bot commented May 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 26, 2023

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8303809: Dispose context in SPNEGO NegotiatorImpl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2023
@mlbridge
Copy link

mlbridge bot commented May 26, 2023

Webrevs

@alexeybakhtin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 31, 2023

Going to push as commit 4267a37.
Since your change was applied there have been 7 commits pushed to the master branch:

  • b2faa35: 8309108: Bump update version for OpenJDK: jdk-11.0.21
  • 1000b1c: 8308884: [17u/11u] Backout JDK-8297951
  • 3613ae4: 8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable
  • 398753e: 8269746: C2: assert(!in->is_CFG()) failed: CFG Node with no controlling input?
  • 9eded68: 8246383: NullPointerException in JceSecurity.getVerificationResult when using Entrust provider
  • 1cbdcc9: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
  • b3d6981: 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 31, 2023
@openjdk openjdk bot closed this May 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@alexeybakhtin Pushed as commit 4267a37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant