Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8226871: invalid use of incomplete type class MacroAssembler when building minimal after JDK-8191278 #191

Closed
wants to merge 1 commit into from

Conversation

snazarkin
Copy link

@snazarkin snazarkin commented Aug 4, 2021

This is follow up for 8191278 that fixes build of arm/aarch64 platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #173 must be integrated first

Issue

  • JDK-8226871: invalid use of incomplete type class MacroAssembler when building minimal after JDK-8191278

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/191/head:pull/191
$ git checkout pull/191

Update a local copy of the PR:
$ git checkout pull/191
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 191

View PR using the GUI difftool:
$ git pr show -t 191

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/191.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into pr/173 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7a1bd6184971f72a8e8dc41a3a9baceb0ab7c52d 8226871: invalid use of incomplete type class MacroAssembler when building minimal after JDK-8191278 Aug 4, 2021
@openjdk
Copy link

openjdk bot commented Aug 4, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr labels Aug 4, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2021

Webrevs

@RealCLanger
Copy link
Contributor

RealCLanger commented Sep 8, 2021

@snazarkin, since this item was rejected by the maintainers, would you mind closing this PR?

@snazarkin snazarkin closed this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr
2 participants