Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument #1911

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 29, 2023

I had to resolve three chunks.

Also, I replaced nullptr by NULL in one place.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1911/head:pull/1911
$ git checkout pull/1911

Update a local copy of the PR:
$ git checkout pull/1911
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1911/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1911

View PR using the GUI difftool:
$ git pr show -t 1911

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1911.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 52324b55fb7be2cd1ba9e843ece93375ac23649c 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument May 29, 2023
@openjdk
Copy link

openjdk bot commented May 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 29, 2023
@mlbridge
Copy link

mlbridge bot commented May 29, 2023

Webrevs

Copy link
Contributor

@rwestrel rwestrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented May 30, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument

Reviewed-by: roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 30, 2023
@GoeLin
Copy link
Member Author

GoeLin commented May 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2023

Going to push as commit 1cbdcc9.
Since your change was applied there has been 1 commit pushed to the master branch:

  • b3d6981: 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2023
@openjdk openjdk bot closed this May 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

@GoeLin Pushed as commit 1cbdcc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8300079 branch May 30, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants