Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale #1913

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented May 30, 2023

I backport this for parity with 11.0.20-oracle.
Set the locale in the DateTimeFormatter to fix the test.
No risk, only a test change.
Tests pass. SAP nightly testing passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1913/head:pull/1913
$ git checkout pull/1913

Update a local copy of the PR:
$ git checkout pull/1913
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1913/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1913

View PR using the GUI difftool:
$ git pr show -t 1913

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1913.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2023

👋 Welcome back luchenlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9a217b931339e8c51fcaf7db474e3c4b2c3f51de 8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 30, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 19bd319: 8212045: Add back the tests that were removed from HashesTest.java and AddExportsTest.java
  • 4267a37: 8303809: Dispose context in SPNEGO NegotiatorImpl
  • b2faa35: 8309108: Bump update version for OpenJDK: jdk-11.0.21
  • 1000b1c: 8308884: [17u/11u] Backout JDK-8297951
  • 3613ae4: 8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable
  • 398753e: 8269746: C2: assert(!in->is_CFG()) failed: CFG Node with no controlling input?
  • 9eded68: 8246383: NullPointerException in JceSecurity.getVerificationResult when using Entrust provider
  • 1cbdcc9: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
  • b3d6981: 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2023
@mlbridge
Copy link

mlbridge bot commented May 30, 2023

Webrevs

@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 5, 2023
@openjdk
Copy link

openjdk bot commented Jun 5, 2023

@luchenlin
Your change (at version 3e27bae) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Jun 6, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 6, 2023

Going to push as commit 7a35741.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 3207e73: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out
  • 81bb36e: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument
  • d917caa: 8297730: C2: Arraycopy intrinsic throws incorrect exception
  • 3ba2a18: 8223573: Replace wildcard address with loopback or local host in tests - part 4
  • 3cdce91: 8217237: HttpClient does not deal well with multi-valued WWW-Authenticate challenge headers
  • 19bd319: 8212045: Add back the tests that were removed from HashesTest.java and AddExportsTest.java
  • 4267a37: 8303809: Dispose context in SPNEGO NegotiatorImpl
  • b2faa35: 8309108: Bump update version for OpenJDK: jdk-11.0.21
  • 1000b1c: 8308884: [17u/11u] Backout JDK-8297951
  • 3613ae4: 8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/8a0b64bf08419204a333d92d09e16e0082d25958...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2023
@openjdk openjdk bot closed this Jun 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 6, 2023
@openjdk
Copy link

openjdk bot commented Jun 6, 2023

@GoeLin @luchenlin Pushed as commit 7a35741.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants