Skip to content

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented May 30, 2023

Please review this backout patch for JDK-8297951 which got included in 11.0.19 release and causes crashes. The patch is the result of git revert de8c37acea0d74524f4f735fef8b03e71a64589f.

Testing:

  • Reproducer from JDK-8307683 crashes the VM before the patch and the crash is gone after.
  • GHA (still running)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1915/head:pull/1915
$ git checkout pull/1915

Update a local copy of the PR:
$ git checkout pull/1915
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1915/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1915

View PR using the GUI difftool:
$ git pr show -t 1915

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1915.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2023

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a93cf5f2b959ba97d5197fe027b81ec69de18382 8308884: [17u/11u] Backout JDK-8297951 May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8308884: [17u/11u] Backout JDK-8297951

This reverts commit de8c37acea0d74524f4f735fef8b03e71a64589f

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2023
@mlbridge
Copy link

mlbridge bot commented May 30, 2023

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented May 30, 2023

/summary add This reverts commit de8c37a

@openjdk
Copy link

openjdk bot commented May 30, 2023

@jerboaa Updating existing summary to add This reverts commit de8c37acea0d74524f4f735fef8b03e71a64589f

@jerboaa
Copy link
Contributor Author

jerboaa commented May 30, 2023

/summary This reverts commit de8c37a

@openjdk
Copy link

openjdk bot commented May 30, 2023

@jerboaa Updating existing summary to This reverts commit de8c37acea0d74524f4f735fef8b03e71a64589f

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@GoeLin
Copy link
Member

GoeLin commented May 30, 2023

Hi @jerboaa, I approved it, please integrate. Our CI pulls soon what I will tag. It starts at 18:00, but first does pull jdk, jdk17 etc.

@jerboaa
Copy link
Contributor Author

jerboaa commented May 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 30, 2023

Going to push as commit 1000b1c.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2023
@openjdk openjdk bot closed this May 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

@jerboaa Pushed as commit 1000b1c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jerboaa
Copy link
Contributor Author

jerboaa commented May 30, 2023

Hi @jerboaa, I approved it, please integrate. Our CI pulls soon what I will tag. It starts at 18:00, but first does pull jdk, jdk17 etc.

OK, integrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants