-
Notifications
You must be signed in to change notification settings - Fork 253
8308884: [17u/11u] Backout JDK-8297951 #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit de8c37a.
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue and summary from the original commit. |
|
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/summary add This reverts commit de8c37a |
|
@jerboaa Updating existing summary to |
|
/summary This reverts commit de8c37a |
|
@jerboaa Updating existing summary to |
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
|
Hi @jerboaa, I approved it, please integrate. Our CI pulls soon what I will tag. It starts at 18:00, but first does pull jdk, jdk17 etc. |
|
/integrate |
|
Going to push as commit 1000b1c. |
OK, integrated. |
Please review this backout patch for JDK-8297951 which got included in 11.0.19 release and causes crashes. The patch is the result of
git revert de8c37acea0d74524f4f735fef8b03e71a64589f.Testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1915/head:pull/1915$ git checkout pull/1915Update a local copy of the PR:
$ git checkout pull/1915$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1915/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1915View PR using the GUI difftool:
$ git pr show -t 1915Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1915.diff
Webrev
Link to Webrev Comment