8274471: Add support for RSASSA-PSS in OCSP Response#1918
8274471: Add support for RSASSA-PSS in OCSP Response#1918apavlyutkin wants to merge 1 commit intoopenjdk:pr/1917from
Conversation
|
👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
Hi, Paul! Could you also check out this one. You've already reviewed the delta here #1891, but then I re-created parent PR from the scratch to avoid huge upmerge. Thank you |
|
@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Please don't close this, bot. |
|
@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
No blocker anymore |
|
/open |
|
@apavlyutkin This pull request is now open |
|
@phohensee Hi Paul! Can you check it? This is a copy of #1891 that has been already reviewed by you but then closed due to problematic rebase. Thank you |
|
@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Hi!
Here is backport of JDK-8274471 adding support of RSASSA-PSS signature to OCSP Response. Original patch applied with the following changes
src/java.base/share/classes/sun/security/provider/certpath/OCSP.javajava.security.cert.TrustAnchorandsun.security.validator.Validatorpackages didn't removed cuz they are still in use;java.nio.charset.StandardCharsets.UTF_8promotingUTF_8constant;src/java.base/share/classes/sun/security/util/SignatureUtil.javasun.security.x509.AlgorithmIdpackage;EdECrelated code droppedSignatureUtil.autoInitInternal()method updated to useAlgorithmId.getDefaultAlgorithmParameterSpec()instead of almost identicalSignatureUtil.getDefaultParamSpec()src/java.base/share/classes/sun/security/x509/AlgorithmId.javapublic byte[] getEncodedParams()does not throw anymoretest/jdk/java/security/testlibrary/CertificateBuilder.javatest/jdk/java/security/testlibrary/SimpleOCSPServer.javasun.security.util.SignatureUtilpackageVerification/regression (amd64/LTS 20.04):
jdk_securityincluding updated tests@phohensee I raised this one in place of already reviewed #1891. Please check it out. Thank you
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1918/head:pull/1918$ git checkout pull/1918Update a local copy of the PR:
$ git checkout pull/1918$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1918/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1918View PR using the GUI difftool:
$ git pr show -t 1918Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1918.diff
Webrev
Link to Webrev Comment