Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296343: CPVE thrown on missing content-length in OCSP response #1920

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented May 31, 2023

Hi!

Here is backport of JDK-8296343. The patch fixes CertPathValidatorException taking place if OCSP response does not contain ContentLength field.

Original patch is applied cleanly except a conflict in Copyright record in src/java.base/share/classes/sun/security/provider/certpath/OCSP.java

Verification (amd64/20.04): newly added test/jdk/sun/security/provider/certpath/OCSP/OCSPNoContentLength.java FAILS, to be fixed by backporting of JDK-8300939 (see #1921)
Regression (amd64/20.04): jdk_security


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8296343 needs maintainer approval

Integration blocker

 ⚠️ Dependency #1918 must be integrated first

Issue

  • JDK-8296343: CPVE thrown on missing content-length in OCSP response (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1920/head:pull/1920
$ git checkout pull/1920

Update a local copy of the PR:
$ git checkout pull/1920
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1920/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1920

View PR using the GUI difftool:
$ git pr show -t 1920

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1920.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2023

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into pr/1918 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 31, 2023

⚠️ @apavlyutkin could not find any commit with hash 46233d158959e61348db6e9add04f8dcbe4b45e7. Please update the title with the hash for an existing commit.

@apavlyutkin apavlyutkin changed the title Backport 46233d158959e61348db6e9add04f8dcbe4b45e7 Backport 1a3cb8c5018bc016c2ad6b078e4abe13b39d151c May 31, 2023
@openjdk openjdk bot changed the title Backport 1a3cb8c5018bc016c2ad6b078e4abe13b39d151c 8296343: CPVE thrown on missing content-length in OCSP response May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 31, 2023
@mlbridge
Copy link

mlbridge bot commented May 31, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2023

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@apavlyutkin
Copy link
Contributor Author

Please don't close this, bot.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2023

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2023

@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Sep 18, 2023
@apavlyutkin
Copy link
Contributor Author

no blocker anymore

@apavlyutkin
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@apavlyutkin This pull request is now open

Copy link

@VladimirKempik VladimirKempik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2023

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2023

@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants