Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors #1921

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented May 31, 2023

Hi!

Here is backport of JDK-8300939 fixing sun/security/provider/certpath/OCSP/OCSPNoContentLength.java test. The patch from 17u applied cleanly.

Verification/regression (amd64/LTS20.04): jdk_security


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8300939 needs maintainer approval

Integration blocker

 ⚠️ Dependency #1920 must be integrated first

Issue

  • JDK-8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1921/head:pull/1921
$ git checkout pull/1921

Update a local copy of the PR:
$ git checkout pull/1921
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1921/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1921

View PR using the GUI difftool:
$ git pr show -t 1921

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1921.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2023

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into pr/1920 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport da044dd5698d14eccd2a30a24cc691e30fa00cbd 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 31, 2023
@apavlyutkin apavlyutkin changed the title 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors Backport 57d0a7f1b69214bd2de951c9907fe1321a66f3b8 May 31, 2023
@openjdk openjdk bot changed the title Backport 57d0a7f1b69214bd2de951c9907fe1321a66f3b8 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the clean label May 31, 2023
@mlbridge
Copy link

mlbridge bot commented May 31, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2023

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2023

@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jul 26, 2023
@apavlyutkin
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@apavlyutkin This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2023

@apavlyutkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2023

@apavlyutkin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant