Skip to content

8223573: Replace wildcard address with loopback or local host in tests - part 4#1924

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:GoeLin-backport-205fd87f
Closed

8223573: Replace wildcard address with loopback or local host in tests - part 4#1924
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:GoeLin-backport-205fd87f

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 2, 2023

I backport this as prerequisite of 8223856 which fixes intermittent issues we see in 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8223573: Replace wildcard address with loopback or local host in tests - part 4

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1924/head:pull/1924
$ git checkout pull/1924

Update a local copy of the PR:
$ git checkout pull/1924
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1924/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1924

View PR using the GUI difftool:
$ git pr show -t 1924

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1924.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 205fd87f2dbaa24bee48d62b8f5ec6e789b8514b 8223573: Replace wildcard address with loopback or local host in tests - part 4 Jun 2, 2023
@openjdk
Copy link

openjdk bot commented Jun 2, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 2, 2023
@openjdk
Copy link

openjdk bot commented Jun 2, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223573: Replace wildcard address with loopback or local host in tests - part 4

Makes a few intermittently failing tests more resilient to port reuse issues by ensuring they bind to the loopback address instead of the wildcard.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 5, 2023

Going to push as commit 3ba2a18.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 3cdce91: 8217237: HttpClient does not deal well with multi-valued WWW-Authenticate challenge headers

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 5, 2023
@openjdk openjdk bot closed this Jun 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2023
@openjdk
Copy link

openjdk bot commented Jun 5, 2023

@GoeLin Pushed as commit 3ba2a18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant