Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC #1935

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 6, 2023

I backport this for parity with 11.0.20-oracle.

Not clean because I had to adapt the test to Java 11 syntax.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1935/head:pull/1935
$ git checkout pull/1935

Update a local copy of the PR:
$ git checkout pull/1935
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1935/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1935

View PR using the GUI difftool:
$ git pr show -t 1935

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1935.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5ba0d09fe47439880daf913f4ff0b978ed9c1ac6 8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC Jun 6, 2023
@openjdk
Copy link

openjdk bot commented Jun 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 6, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 5067ea2: 8239264: Clearup the legacy ObjectIdentifier constructor from int array
  • 185ad54: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes
  • e3dd9dd: 8223856: Replace wildcard address with loopback or local host in tests - part 8

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2023

Webrevs

@RealCLanger
Copy link
Contributor

Although clean backport, the test does not compile - due to newer Java features used than available in 11. Please check.

@openjdk openjdk bot removed clean ready Pull request is ready to be integrated labels Jun 12, 2023
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 13, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jun 14, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 14, 2023

Going to push as commit ad3a90f.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 5067ea2: 8239264: Clearup the legacy ObjectIdentifier constructor from int array
  • 185ad54: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes
  • e3dd9dd: 8223856: Replace wildcard address with loopback or local host in tests - part 8

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 14, 2023
@openjdk openjdk bot closed this Jun 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 14, 2023
@openjdk
Copy link

openjdk bot commented Jun 14, 2023

@GoeLin Pushed as commit ad3a90f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants