-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8274205: Handle KDC_ERR_SVC_UNAVAILABLE error code from KDC #1935
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
Although clean backport, the test does not compile - due to newer Java features used than available in 11. Please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
/integrate |
Going to push as commit ad3a90f.
Your commit was automatically rebased without conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I backport this for parity with 11.0.20-oracle.
Not clean because I had to adapt the test to Java 11 syntax.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1935/head:pull/1935
$ git checkout pull/1935
Update a local copy of the PR:
$ git checkout pull/1935
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1935/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1935
View PR using the GUI difftool:
$ git pr show -t 1935
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1935.diff
Webrev
Link to Webrev Comment