New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8201516: DebugNonSafepoints generates incorrect information #1936
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 16e40e4.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.20-oracle.
It applied clean, but to build I had to replace nullptr by NULL.
The test does not work in 11 as it requires the ir_testframework that
is not available here.
I added @ignore, this way it will not be run, but it's in the
test suite in case the framework is backported at some point.
Progress
Issue
"3"
)Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1936/head:pull/1936
$ git checkout pull/1936
Update a local copy of the PR:
$ git checkout pull/1936
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1936/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1936
View PR using the GUI difftool:
$ git pr show -t 1936
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1936.diff
Webrev
Link to Webrev Comment