-
Notifications
You must be signed in to change notification settings - Fork 251
8304291: [AIX] Broken build after JDK-8301998 #1940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8304291: [AIX] Broken build after JDK-8301998 #1940
Conversation
|
👋 Welcome back afarley! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@adamfarley This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@martinuy) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@adamfarley |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Adam,
Thanks for contributing this backport. Looks clean to me.
If we get a jdk11u Maintainer approval for the jdk11u-critical-request
request (https://bugs.openjdk.org/browse/JDK-8304291), I'll sponsor this PR. As commented here, integration cannot occur before a Maintainer approval.
Regards,
Martin.-
|
Hi, @martinuy: This is a build breakage for 11.0.20 on AIX so we need it in jdk11u. So the other PR is the correct one. @adamfarley: Please never do Thanks |
|
Thanks for letting me know Christoph. Will close this PR now. |
Hi all,
This pull request contains a backport of commit 310aa934 from the openjdk/jdk repository.
The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1940/head:pull/1940$ git checkout pull/1940Update a local copy of the PR:
$ git checkout pull/1940$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1940/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1940View PR using the GUI difftool:
$ git pr show -t 1940Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1940.diff
Webrev
Link to Webrev Comment