Skip to content

Conversation

@adamfarley
Copy link

@adamfarley adamfarley commented Jun 9, 2023

Hi all,

This pull request contains a backport of commit 310aa934 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 20 Apr 2023 and was reviewed by Martin Doerr, Tyler Steele and Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8304291: [AIX] Broken build after JDK-8301998 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1940/head:pull/1940
$ git checkout pull/1940

Update a local copy of the PR:
$ git checkout pull/1940
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1940/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1940

View PR using the GUI difftool:
$ git pr show -t 1940

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1940.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2023

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 310aa9347861922af5f0311e9e93a5f49dee6adc 8304291: [AIX] Broken build after JDK-8301998 Jun 9, 2023
@openjdk
Copy link

openjdk bot commented Jun 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 9, 2023
@openjdk
Copy link

openjdk bot commented Jun 9, 2023

@adamfarley This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8304291: [AIX] Broken build after JDK-8301998

Reviewed-by: mbalao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@martinuy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 9, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2023

Webrevs

@adamfarley
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 9, 2023
@openjdk
Copy link

openjdk bot commented Jun 9, 2023

@adamfarley
Your change (at version 1c12122) is now ready to be sponsored by a Committer.

Copy link
Contributor

@martinuy martinuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Adam,

Thanks for contributing this backport. Looks clean to me.

If we get a jdk11u Maintainer approval for the jdk11u-critical-request
request (https://bugs.openjdk.org/browse/JDK-8304291), I'll sponsor this PR. As commented here, integration cannot occur before a Maintainer approval.

Regards,
Martin.-

@RealCLanger
Copy link
Contributor

Hi,

@martinuy: This is a build breakage for 11.0.20 on AIX so we need it in jdk11u. So the other PR is the correct one.

@adamfarley: Please never do /integrate unless there is maintainer approval via the appropriate label in JBS. And please close this PR, sorry for the additional churn.

Thanks
Christoph

@adamfarley
Copy link
Author

Thanks for letting me know Christoph. Will close this PR now.

@adamfarley adamfarley closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored

Development

Successfully merging this pull request may close these issues.

3 participants