8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address

[backwaterred]

This PR backports the change reported in JDK-8305906.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8305906 needs maintainer approval

Issue

• JDK-8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1941/head:pull/1941
$ git checkout pull/1941

Update a local copy of the PR:
$ git checkout pull/1941
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1941/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1941

View PR using the GUI difftool:
$ git pr show -t 1941

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1941.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@backwaterred This change is no longer ready for integration - check the PR body for details.

[mlbridge]

Webrevs

• 00: Full (fbbc5e87)

[GoeLin]

I ran this through our nightly testing. I see java/net/httpclient/http2/ConnectionReuseTest.java failing.
It says: test result: Error. Can't find library: /test/jdk/java/net/httpclient/lib

[backwaterred]

@GoeLin Thanks for mentioning this. I will see if I can replicate on our machines and diagnose.

[bridgekeeper]

@backwaterred This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[backwaterred]

Bump

[bridgekeeper]

@backwaterred This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@backwaterred This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.