Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1 #1946

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 15, 2023

I backport this for parity with 11.0.20-oracle.

I had to resolve RSAPrivateCrtKeyImpl.java.
Besides context, newKey() is refactored in 11 because
8271199: Mutual TLS handshake fails signing client certificate with c...
is already backported.

TestKeyFactory.java
manual resolve. Some of the edits are already there (in testPrivate()).
They probably came with 8254717.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1 (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1946/head:pull/1946
$ git checkout pull/1946

Update a local copy of the PR:
$ git checkout pull/1946
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1946

View PR using the GUI difftool:
$ git pr show -t 1946

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1946.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 68cf65d284a73f5c5229d30ca642bba9585095f3 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1 Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 15, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2023

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.
I noticed that
src/java.base/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java
public static RSAPrivateKey newKey(KeyType type, String format, byte[] encoded)
The
case "PKCS#8"
differs from the change in head, but it seems to be okay as it is, but maybe you want to check it again if the diff is really wanted.

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jun 16, 2023

Looks okay to me. I noticed that src/java.base/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java public static RSAPrivateKey newKey(KeyType type, String format, byte[] encoded) The case "PKCS#8" differs from the change in head, but it seems to be okay as it is, but maybe you want to check it again if the diff is really wanted.

The call to checkComponents() is intendend. That is from a later change that was backported before.

@GoeLin
Copy link
Member Author

GoeLin commented Jun 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

Going to push as commit 0b7efe4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 16, 2023
@openjdk openjdk bot closed this Jun 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@GoeLin Pushed as commit 0b7efe4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8023980 branch June 16, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants