Skip to content

8255348: NPE in PKIXCertPathValidator event logging code #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 15, 2023

I backport this for parity with 11.0.20-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8255348: NPE in PKIXCertPathValidator event logging code (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1947/head:pull/1947
$ git checkout pull/1947

Update a local copy of the PR:
$ git checkout pull/1947
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1947/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1947

View PR using the GUI difftool:
$ git pr show -t 1947

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1947.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 18eb6d9e34afa0df168c1794a9a41b23e5a17915 8255348: NPE in PKIXCertPathValidator event logging code Jun 15, 2023
@openjdk
Copy link

openjdk bot commented Jun 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 15, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255348: NPE in PKIXCertPathValidator event logging code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

  • 09685c8: 8155246: Throw error if default java.security file is missing
  • c1939dd: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes
  • d7701cd: 8242897: KeyFactory.generatePublic( x509Spec ) failed with java.security.InvalidKeyException
  • ad283ae: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • c1bb926: 8309138: Fix container tests for jdks with symlinked conf dir
  • 3bc72d0: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration
  • 26652c8: 8308156: VerifyCACerts.java misses blank in error output
  • c1b7fd2: 8223714: HTTPSetAuthenticatorTest could be made more resilient
  • 9fe6ade: 8229912: [TESTBUG] java/net/Socks/SocksIPv6Test fails without IPv6
  • 0fdd6dd: 8224617: (fs) java/nio/file/FileStore/Basic.java found filesystem twice
  • ... and 60 more: https://git.openjdk.org/jdk11u-dev/compare/8c243a33b290f5e747ee227f005d30260e6d846f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 15, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 16, 2023

Going to push as commit d981db8.
Since your change was applied there have been 72 commits pushed to the master branch:

  • d5d3981: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check
  • 0b7efe4: 8023980: JCE doesn't provide any class to handle RSA private key in PKCS#1
  • 09685c8: 8155246: Throw error if default java.security file is missing
  • c1939dd: 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes
  • d7701cd: 8242897: KeyFactory.generatePublic( x509Spec ) failed with java.security.InvalidKeyException
  • ad283ae: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML
  • c1bb926: 8309138: Fix container tests for jdks with symlinked conf dir
  • 3bc72d0: 8242151: Improve OID mapping and reuse among JDK security providers for aliases registration
  • 26652c8: 8308156: VerifyCACerts.java misses blank in error output
  • c1b7fd2: 8223714: HTTPSetAuthenticatorTest could be made more resilient
  • ... and 62 more: https://git.openjdk.org/jdk11u-dev/compare/8c243a33b290f5e747ee227f005d30260e6d846f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 16, 2023
@openjdk openjdk bot closed this Jun 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

@GoeLin Pushed as commit d981db8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant