Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM #1951

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 16, 2023

I backport this for parity with 11.0.20-oracle form 17.

in loopTransform, I had to adapt the make_cast() call because
ConstraintCastNode::UnconditionalDependency is not in 11.
I think 'true" is the right thing here.

Also I removed a test case becasue -XX:StressSeed is not in 11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM (Bug - P3)
  • JDK-8301959: Compile command in compiler.loopopts.TestRemoveEmptyCountedLoop does not work (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1951/head:pull/1951
$ git checkout pull/1951

Update a local copy of the PR:
$ git checkout pull/1951
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1951/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1951

View PR using the GUI difftool:
$ git pr show -t 1951

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1951.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2b5b9f59152e11ed76ce838e1e1e09b09b7a5206 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM Jun 16, 2023
@openjdk
Copy link

openjdk bot commented Jun 16, 2023

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 16, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
8301959: Compile command in compiler.loopopts.TestRemoveEmptyCountedLoop does not work

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 2cc4596: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
  • c1f759e: 8305815: Update Libpng to 1.6.39

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 19, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jun 20, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

Going to push as commit 20fe22f.
Since your change was applied there have been 10 commits pushed to the master branch:

  • e6aba91: 8229333: java/io/File/SetLastModified.java timed out
  • defa0b2: 8232195: Enable BigInteger tests: DivisionOverflow, SymmetricRangeTests and StringConstructorOverflow
  • 4452721: 8229338: clean up test/jdk/java/util/RandomAccess/Basic.java
  • 273987b: 8231357: sun/security/pkcs11/Cipher/TestKATForGCM.java fails on SLES11 using mozilla-nss-3.14
  • 0eb4503: 8231037: java/net/InetAddress/ptr/Lookup.java fails intermittently due to reverse lookup failed
  • dda5ed2: 8226221: Update PKCS11 tests to use NSS 3.46 libs
  • ade9973: 8230132: java/net/NetworkInterface/NetworkInterfaceRetrievalTests.java to skip Teredo Tunneling Pseudo-Interface
  • 64c9026: 8300751: [17u] Remove duplicate entry in javac.properties
  • 2cc4596: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
  • c1f759e: 8305815: Update Libpng to 1.6.39

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2023
@openjdk openjdk bot closed this Jun 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@GoeLin Pushed as commit 20fe22f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8289748 branch June 20, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants