8254350: CompletableFuture.get may swallow InterruptedException #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back luchenlin! A progress list of the required criteria for merging this PR into |
|
/issue JDK-8254350 |
openjdk
bot
changed the title
|
@luchenlin The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
|
/issue add JDK-8259796 |
|
@luchenlin |
|
Backport 43dc3f7 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I backport this for parity with 11.0.20-oracle.
Also backport for JDK-8259796
src/java.base/share/classes/java/util/concurrent/CompletableFuture.java
Resolved due to context
test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java
Resolved due to context
test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java
Resolved due to context
Progress
Issues
Backport <hash>with the hash of the original commit. See Backports.Backport <hash>with the hash of the original commit. See Backports.Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1961/head:pull/1961$ git checkout pull/1961Update a local copy of the PR:
$ git checkout pull/1961$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1961/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1961View PR using the GUI difftool:
$ git pr show -t 1961Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1961.diff
Webrev
Link to Webrev Comment