Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254350: CompletableFuture.get may swallow InterruptedException #1961

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jun 19, 2023

I backport this for parity with 11.0.20-oracle.
Also backport for JDK-8259796
src/java.base/share/classes/java/util/concurrent/CompletableFuture.java
Resolved due to context
test/jdk/java/util/concurrent/CompletableFuture/LostInterrupt.java
Resolved due to context
test/jdk/java/util/concurrent/CompletableFuture/SwallowedInterruptedException.java
Resolved due to context


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8254350: CompletableFuture.get may swallow InterruptedException (Bug - P3) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.
  • JDK-8259796: timed CompletableFuture.get may swallow InterruptedException (Bug - P2) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1961/head:pull/1961
$ git checkout pull/1961

Update a local copy of the PR:
$ git checkout pull/1961
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1961

View PR using the GUI difftool:
$ git pr show -t 1961

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1961.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2023

👋 Welcome back luchenlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@luchenlin
Copy link
Contributor Author

/issue JDK-8254350

@openjdk openjdk bot changed the title Backport 43dc3f79 8254350: CompletableFuture.get may swallow InterruptedException Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@luchenlin The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 19, 2023
@luchenlin
Copy link
Contributor Author

/issue add JDK-8259796

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@luchenlin
Adding additional issue to issue list: 8259796: timed CompletableFuture.get may swallow InterruptedException.

@mlbridge
Copy link

mlbridge bot commented Jun 19, 2023

Webrevs

@luchenlin
Copy link
Contributor Author

Backport 43dc3f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
1 participant