Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234808: jdb quoted option parsing broken #1962

Closed
wants to merge 2 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jun 19, 2023

I backport this for parity with 11.0.20-oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8234808: jdb quoted option parsing broken (Bug - P3) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1962/head:pull/1962
$ git checkout pull/1962

Update a local copy of the PR:
$ git checkout pull/1962
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1962/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1962

View PR using the GUI difftool:
$ git pr show -t 1962

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1962.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2023

👋 Welcome back luchenlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@luchenlin
Copy link
Contributor Author

/issue JDK-8234808

@openjdk openjdk bot changed the title Backport d1f9b8a8 8234808: jdb quoted option parsing broken Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@luchenlin The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2023

Webrevs

@luchenlin luchenlin closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
1 participant