You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a backport of JDK-8309959: JFR: Display N/A for missing data amount.
It is a follow up to the backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE
NB: ValueFormatter.java that is changed in the original commit got introduced with JDK-8306703. which is JDK 21+ only and shouldn't get backported.
👋 Welcome back fthevenet! A progress list of the required criteria for merging this PR into pr/1942 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
openjdkbot
changed the title
Backport 9872a14192ce3964b934c19ab685342ffd396986
8309959: JFR: Display N/A for missing data amount
Jun 20, 2023
@fthevenet This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again.
@fthevenet This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@fthevenet This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportPort of a pull request already in a different code baserfrPull request is ready for review
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of JDK-8309959: JFR: Display N/A for missing data amount.
It is a follow up to the backport of JDK-8309550: jdk.jfr.internal.Utils::formatDataAmount method should gracefully handle amounts equal to Long.MIN_VALUE
NB: ValueFormatter.java that is changed in the original commit got introduced with JDK-8306703. which is JDK 21+ only and shouldn't get backported.
A run of the Jdk_jfr test suite via GHA will be available here: https://github.com/fthevenet/jdk11u-dev/actions/runs/5324629652
Thanks
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1969/head:pull/1969$ git checkout pull/1969Update a local copy of the PR:
$ git checkout pull/1969$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1969/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1969View PR using the GUI difftool:
$ git pr show -t 1969Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1969.diff
Webrev
Link to Webrev Comment